fix for critical bug in query handover and minor bug in TableView::re_sort, and improvements to tests #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er, which can cause corruption
finnschiermer
changed the title
|
Coverage: 100% Please check your coverage here: https://ci.realm.io/job/core_matrix_pr/857/buildcommand=jenkins-pipeline-coverage,buildtype=debug,encryption=no,slave=FastLinux/Diff_Coverage/ |
Closed
| @@ -97,10 +97,6 @@ Query::Query(const Query& copy, const TCopyExpressionTag&) | |||
|
|
|||
| void Query::copy_nodes(const Query& source) | |||
| { | |||
| m_table = source.m_table; | |||
There was a problem hiding this comment.
great to have these removed, they seem redundant for all calls to copy_nodes
|
👍 |
finnschiermer
added a commit
that referenced
this pull request
Sep 4, 2015
fix for critical bug in query handover and minor bug in TableView::re_sort, and improvements to tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a Query (as part of handover) we accidentally leaked table references which should have stayed within the exporting shared group. Depending upon timing, this may lead to double deletion, wrong results af import or crashes.
The minor bug in re_sort() could cause imperative tableviews to grow (but only with detached refs) as a side effect of re-sorting. Unlikely to have been seen by anyone, as re_sort() is not used publicly