Set the last seen version correctly for TableViews created from queries on LinkViews #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es on LinkViews The initial last seen version was always being set to the target's version, while is_in_sync() uses the origin table's version. This normally just resulted in the query being rerun when it didn't need to be, but could theoretically result in it not being rerun when needed given sufficiently bad luck.
|
Coverage: 100% Please check your coverage here: https://ci.realm.io/job/core_matrix_pr/1507/buildcommand=jenkins-pipeline-coverage,buildtype=debug,encryption=no,slave=fastlinux/Diff_Coverage/ |
|
Nice catch :-) 👍 |
|
Nice cleanup. 👍 |
finnschiermer
added a commit
that referenced
this pull request
Dec 10, 2015
Set the last seen version correctly for TableViews created from queries on LinkViews
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial last seen version was always being set to the target's version, while is_in_sync() uses the origin table's version. This normally just resulted in the query being rerun when it didn't need to be, but could theoretically result in it not being rerun when needed given sufficiently bad luck.