Make posix_fallocate robust against interruption, report right errors #2905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
man posix_fallocate states:
With this in mind, we should report the return value and not the value in
errno
.Additionally,
EINTR
is reported as a return code in fedora 24 (but strangely not mentioned in ubuntu 16). If it is interrupted, we can retry. It is hard to guess what the result of an interruptedposix_fallocate
call would result in if not retried; the file would not be the expected size so this may fix errors like #2258.