Feature: Float, Double support. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Added support for Mixed. Also fixed int support for negative values and full 64-bit values. |
| void find_all(Array& result, T value, size_t add_offset = 0, size_t start = 0, size_t end = -1); | ||
|
|
||
| size_t count(T value, size_t start=0, size_t end=-1) const; | ||
| double sum(size_t start=0, size_t end=-1) const; |
There was a problem hiding this comment.
Returns double even though this is an abstract array. Consider add in a template type parameter that specifies the return type. This type should then also be used for the accumulator.
There was a problem hiding this comment.
sum() is now disabled, since it's unused by other classes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
float and double datatypes now supported.
Note: this also includes new Query optimizations from Lasse.
Also with mixed support now.
Still missing:
/cc @kspangsege @astigsen