Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for problem with async write use of encryption #5369

Merged
merged 3 commits into from
Apr 6, 2022
Merged

fix for problem with async write use of encryption #5369

merged 3 commits into from
Apr 6, 2022

Conversation

finnschiermer
Copy link
Contributor

@finnschiermer finnschiermer commented Mar 31, 2022 •
edited
Loading

What, How & Why?

Fixes a future problem with async write not using encryption correctly.

Originally (mistakenly) proposed as a fix for encryption meta-issue #5360

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)

@cla-bot cla-bot bot added the cla: yes label Apr 5, 2022
@finnschiermer finnschiermer requested a review from jedelbo April 6, 2022 07:41
jedelbo
jedelbo approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@finnschiermer finnschiermer merged commit 617d610 into master Apr 6, 2022
@finnschiermer finnschiermer deleted the fsa/fix-async-write-encryption branch April 6, 2022 11:47
@finnschiermer finnschiermer restored the fsa/fix-async-write-encryption branch April 8, 2022 11:47
@finnschiermer finnschiermer deleted the fsa/fix-async-write-encryption branch April 8, 2022 11:48
@finnschiermer finnschiermer changed the title fix for encryption/async-write bugs (#5360) fix for problem with async write use of encryption Apr 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jedelbo jedelbo jedelbo approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnschiermer @jedelbo