simplified encryption management #5375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make sure I'm understanding this correctly: the idea here is that in normal usage we no longer ever have multiple mutable mappings of the same file active at a time, so we don't need to update other mappings? As long as there's only ever one DB opening a file, the other mappings are just old reader views which should continue to see the same old data anyway, and copying between mappings only makes sense with multiple DB instances (or multiple SharedGroups before the SharedGroup mapping sharing was implemented). |
|
@tgoyne nope, the simplification here is removal of dead code. But please let me know if you think I'm removing code which is in use? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos