-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fsa/new version management #5440
Conversation
8188012
to
6ff1cdd
Compare
1ba9523
to
0061000
Compare
Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
54aa462
to
074ad5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be the last roundtrip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🇮🇹!
(after fixing a minor typo)
Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
In case you missed it, there are 20 new warnings reported on CI "Code will never be executed" around calls to |
Reclaim intermediate (frozen) versions.
This PR holds two major upgrades
Testing is done by two random scenarios, one at Core Storage level, one at ObjectStore level. The tests generate scenarios with random use of both live version pinning, frozen version pinning and dropping of versions. The test at ObjectStore level uses notifications. In debug mode every use of the backdating algorithm includes verification that a) recycled blocks are not referenced and b) kept blocks are indeed referenced. This validation is expensive, so only enabled in debug mode.
The complexity is O(free-list-size * log2(max(versions,free-list-size)) so it may add CPU overhead to commit. However, recycling blocks earlier often leads to less fragmentation and shorter free-lists. The observed net result for the tests is a clear performance win.