Use address space reservation to minimize allocations. #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for encryption yet.
finnschiermer
force-pushed
the
fsa/reserve-for-mmap
branch
3 times, most recently
from
d626846 to
23db073
Compare
finnschiermer
force-pushed
the
fsa/reserve-for-mmap
branch
from
23db073 to
cdcef9e
Compare
ironage
reviewed
Jul 12, 2022
ironage
approved these changes
Jul 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may lower use of virtual address space on platforms where address space reservation is possible.
This mitigates a problem where incremental growth of the realm file along with some limited version pinning could lead to excess allocation of virtual address space - which is a problem on platforms with very limited virtual address space.
Implemented for both encrypted and non-encrypted realms.
What, How & Why?
☑️ ToDos