Throw exception if flx sync during realm conversation (fix flacky test) #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fdb1290.
nicola-cab
changed the title
|
Is this failing because it's sometimes connecting to the server and receiving an error before it gets torn down? If so you could fix the test by stopping the server first. |
jedelbo
approved these changes
Sep 19, 2022
jedelbo
deleted the
nc/throw_exception_if_flx_sync_during_realm_conversation
branch
I know, but the test is really not useful to be honest. So I preferred deleting it. |
tgoyne
added a commit
that referenced
this pull request
Sep 19, 2022
…nification * origin/master: Improve type check when casting to WrapC Updated release notes Throw exception if flx sync during realm conversation (fix flacky test) (#5869) Update install-baas to use go 1.18.6 (#5863) throw inside realm convert if realm uses flx sync (#5846) Update release notes Prepare release Store an optional Query on TableView Replace the typed aggregate functions with simpler untyped ones Add basic benchmarks for aggregate operations Add non-installed headers to the CMake project Remove a double-lookup when reading Dictionary values by index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Delete spuriously failing test.
☑️ ToDos