Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzer Framework #5940
Fuzzer Framework #5940
Changes from 158 commits
0fa075e
ddd2c1a
19027a1
85c999f
1fe1da0
70d7bf4
7cf6411
73a28f0
d111728
0b16041
d8cc443
30cb356
51b9b3f
bbd3cfe
89c3381
15a61cf
4c569da
a574d88
a5a3e31
22379e1
dfa6646
c978ad2
a65267e
6763a8a
a5e49db
4ad5408
dcf2267
9e50175
48f79c6
7c6a2b8
d6156eb
98a7e77
aec4c77
91e4c2d
585e0ea
6fbf9ca
3a8af67
8535fe3
97f65b4
3ef6e22
1753b20
1efb701
a29f4c3
b1dea82
8082cb2
8b0f4ed
3b26962
b097258
66d6791
bdf1517
6de6c68
56b41c3
2caa486
b468cbb
f86bf68
e8078d8
b0300c2
1be6f6b
3e3f757
d7034e3
908cc1b
26b1cfb
58d86fa
dfc76b1
dfaa03d
88c2405
f4855a6
cc75925
4a7ccc4
7848dbe
92c6de2
45c2d25
9c65f6b
417792b
7836c8c
76b3690
c944d82
e6a99e3
e7d6c2b
e04aa57
4232bca
d900dd0
4558c36
0c1a355
bb8727b
4d8ad3c
e47ccb0
c3cbf06
1a155ab
5868931
216f42f
695e33d
ed60633
6f73ae2
fd9fd42
ee241ae
8ca4cdf
0053aa4
93863ec
9832d74
810729c
0dcc548
71deb5b
e57c557
003a536
96d6c03
5e47421
a6bd9ee
a773bde
4c42fe6
65d28d5
8a52a89
1a6a44b
dfd16ae
3561b15
4f66ee2
4bc951a
40d7218
e090c4a
106ba7c
0b37563
6e943ce
690ec81
26e6232
fe367ee
bc3cf97
0fdd865
4f2c57b
db8cbb0
2f6cdde
200573a
1f03f05
d87484f
7461d5a
772d825
33b1fbe
6c7ea4f
990acf1
cc37f08
49b978d
937a36b
54b3943
52f1369
d0115c4
34a75a4
6d2fae3
af0ed29
165ba21
bdf8e91
e6223aa
847c8c1
e67002e
a7f9cad
14bedb6
a43147a
5d071e1
d702196
27d7d1e
2f05d63
1406fe1
714677b
d1d292a
f37edc1
0f86d13
89f1fa7
86adb58
ce14bb4
117ea1c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason behind removing this option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed the CMake file, dependencies are always fetched if needed. Check the rest of the cmake file. I haven't removed the option. I needed to have libUV exported 'above' object store in order to link it in the fuzzer. The reason why I need this is because right now the fuzzer lives outside the object store folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not sure why we would need to change this file. I can build without the change and I would prefer not to be forced to download and build libuv.