Make getting a complete view of the schema optional #6211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/schema-view
branch
2 times, most recently
from
2e5668b to
9f23885
Compare
nicola-cab
approved these changes
Jan 19, 2023
| }); | ||
|
|
||
| if (!other_classes.empty()) { | ||
| insert(end(), other_classes.begin(), other_classes.end()); | ||
| reserve(size() + other_classes.size()); |
There was a problem hiding this comment.
I think this is equivalent to call directly insert.
There was a problem hiding this comment.
It's almost certainly not a useful optimization outside of very weird things, but this eliminates some moves by gathering pointers to the schema to copy and then constructing the copies in-place.
Rather than tying this to the Additive schema mode, make it an option which can be used with all applicable schema modes. This also fixes several bugs in the implementation which would result in it failing to actually have a complete view of the schema in some cases, and could result in frozen Realms having an incorrect schema. This also incidentally improves the performance of freezing Realms as part of the fix for the schema management and fixes a few race conditions related to cached frozen Realms.
tgoyne
force-pushed
the
tg/schema-view
branch
from
9f23885 to
c1967c1
Compare
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than tying this to the Additive schema mode, make it an option which can be used with all applicable schema modes. It turns out that adding additional properties to the end of persisted_properties does cause problems, as it makes
Object::create()expect values for those properties. However, we do (sometimes) want the additional tables to be added to the schema and not just in Additive mode, so that's a separate option.This also fixes several bugs in the implementation which would result in it failing to actually have a complete view of the schema in some cases, and could result in frozen Realms having an incorrect schema.
This also incidentally improves the performance of freezing Realms as part of the fix for the schema management and fixes a few race conditions related to cached frozen Realms.