Add REALM_SYNC_PROTOCOL_V8 compile flag to enable sync proto v8 features #6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Added
REALM_SYNC_PROTOCOL_V8compile flag to enable sync protocol v8 features:Sec-WebSocket-Protocollist in the websocket connect header to use#instead of/, which is compatible with the JS/browser websocket implementation used for WASMAlso made some minor updates to the doc/protocol.md document.
NOTE: A changelog update is not needed since the compile flag is for internal use only and will be removed when these features are released.
Fixes #6395
☑️ ToDos
[ ] 📝 Changelog update[ ] C-API, if public C++ API changed.