More detailed error message for SystemError exceptions #6756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the expected error for the "Disabled user results in a sync error" test (test/object-store/sync/app.cpp:2874) needs to be updated as well. |
nicola-cab
approved these changes
Jun 29, 2023
| { | ||
| std::error_code err = std::make_error_code(std::errc::too_many_files_open); | ||
| std::string_view message = "my message"; | ||
| std::string expected = util::format("%1 (SystemError %2: %3)", message, err.value(), "Too many open files"); |
There was a problem hiding this comment.
CHECK_STRING_CONTAINS(e.what(), expected) failed with (my message (SystemError 24: too many files open), my message (SystemError 24: Too many open files)) ... Only on Windows though.
There was a problem hiding this comment.
Thanks. Windows seems to provide a slightly different error message, so I've adjusted the tests accordingly.
There was a problem hiding this comment.
Of course Windows just has to be different
michael-wb
approved these changes
Jun 29, 2023
| { | ||
| std::error_code err = std::make_error_code(std::errc::too_many_files_open); | ||
| std::string_view message = "my message"; | ||
| std::string expected = util::format("%1 (SystemError %2: %3)", message, err.value(), "Too many open files"); |
There was a problem hiding this comment.
Of course Windows just has to be different
This was referenced Jul 6, 2023
nicola-cab
pushed a commit
that referenced
this pull request
Jul 12, 2023
* a more detailed error message for SystemError exceptions * update error message * fix windows message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues like #6739 would be much easier to diagnose if the reported exception message had the details about what the error code was. The std error code was already stored there, so this change just appends the details to the existing message.
☑️ ToDos