Fix query on size of a single link over links #6918
Conversation
CHANGELOG.md
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| ### Fixed | |||
| * <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?) | |||
| * None. | |||
| * Crash when querying the size of a Object property in a linked/linked to object ([#6915](https://github.com/realm/realm-core/issues/6915), since v13.17.2) | |||
There was a problem hiding this comment.
What linked/linked stands for?
There was a problem hiding this comment.
Yes, this is not entirely readable. The query should be on the size of an Object property on an object that is linked from the base object. The link can either be forward or backward. I will try to rephrase
| @@ -519,11 +519,16 @@ void LinkCount::evaluate(size_t index, ValueBase& destination) | |||
| const Obj obj = m_link_map.get_target_table()->get_object(links[i]); | |||
| auto val = obj._get<int64_t>(m_column_key.get_index()); | |||
| size_t s; | |||
| if (val & 1) { | |||
| if (m_column_key.get_type() == col_type_Link && !m_column_key.is_collection()) { | |||
There was a problem hiding this comment.
Do I read this correctly? You are trying to avoid to deal with collections of links? Right?
There was a problem hiding this comment.
Yes. We must handle single link columns separately. That was the problem.
| // It is a single link column | ||
| s = (val == 0) ? 0 : 1; | ||
| } | ||
| else if (val & 1) { |
There was a problem hiding this comment.
How can you be sure that, at this point, we are dealing with a simple backlink column that points to one value? I guess what I am trying to say, is that... the logic behind val == 0 vs val == 1 is a little bit obscure, does val represents a simple boolean flag?....
There was a problem hiding this comment.
Maybe a bit obscure. The only case where we can have a tagged value here is when we are dealing with a backlink column with a single link. All other cases we have a ref to bplustree of links.
There was a problem hiding this comment.
OK maybe we can use a comment here. Describing this.
There was a problem hiding this comment.
There is actually a comment
| // It is a single link column | ||
| s = (val == 0) ? 0 : 1; | ||
| } | ||
| else if (val & 1) { |
There was a problem hiding this comment.
OK maybe we can use a comment here. Describing this.
What, How & Why?
Fixes #6915
☑️ ToDos