Fix deadlock when accessing user instance from within a listener #7186
Conversation
Pull Request Test Coverage Report for Build andrew.meyer_4
💛 - Coveralls |
| // m_current_user is normally set very indirectly via the metadata manger | ||
| if (!m_metadata_manager) | ||
| m_current_user = new_user; | ||
| auto user = std::shared_ptr<SyncUser>(nullptr); |
There was a problem hiding this comment.
std::shared_ptr<SyncUser> user; is the normal way to write this.
* Remove lock before calling `log_in` * Add test for deadlock
takameyer
force-pushed
the
andrew/double-login
branch
from
5293314 to
82cb295
Compare
takameyer
requested review from
jedelbo
and removed request for
jbreams and
michael-wb
Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com>
| else { // LoggedOut => LoggedIn | ||
| auto user = *it; | ||
|
|
||
| // LoggedOut => LoggedIn |
There was a problem hiding this comment.
I don't know what this comment means anymore? I guess we're in in get_user() which implies we don't have a logged in user?
There was a problem hiding this comment.
I think this case assumes a cached user is changing to a logged in state, but in the case I'm testing against, we are updating the current logged in users auth tokens.
Comment could probably be removed or adapted.
There was a problem hiding this comment.
I'd say just remove it. I don't think it was adding much context.
There was a problem hiding this comment.
There was originally comments like this for each of the User state transitions, but they weren't maintained as the code was modified/
What, How & Why?
log_inFixes #7183
☑️ ToDos
bindgen/spec.yml, if public C++ API changed