Gracefully handle all exceptions during bootstrap processing #7197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build jonathan.reams_2983
💛 - Coveralls |
jbreams
force-pushed
the
jbr/handle_all_exceptions_from_bootstrapping
branch
from
b5f570b to
763ca5b
Compare
| check_interrupted_state(realm); | ||
| } | ||
|
|
||
| auto realm = Realm::get_shared_realm(interrupted_realm_config); |
There was a problem hiding this comment.
This part is the second attempt on applying the bootstrap changes (and it is successful this time). you could consider adding a comment.
tgoyne
approved these changes
Dec 13, 2023
…ptions_from_bootstrapping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This makes sure we catch exceptions getting thrown during bootstrap application and surface them to the user via the sync error handler. It also fixes one place during session activation where we were not exception-safe which may have caused an uncaught exception to manifest as a
REALM_ASSERT(!m_sess)failure rather than a regular uncaught exception.☑️ ToDos
bindgen/spec.yml, if public C++ API changed