Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2148 Reconnect Hang Analyzer to evergreen #7719

Merged
merged 1 commit into from
May 30, 2024

Conversation

jsflax
Copy link
Contributor

@jsflax jsflax commented May 22, 2024

The hang analyzer became disconnected due to a variable working dir, incorrect precondition checks on the requirements.txt file, and the python venv being updated to 3.12.

Copy link

coveralls-official bot commented May 22, 2024

Pull Request Test Coverage Report for Build jason.flax_720

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1128 unchanged lines in 24 files lost coverage.
  • Overall coverage increased (+0.008%) to 90.817%

Files with Coverage Reduction New Missed Lines %
src/realm/index_string.hpp 1 93.48%
src/realm/object-store/c_api/types.hpp 1 77.12%
src/realm/sync/client.hpp 1 97.73%
src/realm/sync/network/default_socket.hpp 1 94.12%
src/realm/util/file.cpp 1 78.73%
test/test_index_string.cpp 1 93.48%
src/realm/list.cpp 2 85.69%
src/realm/sync/network/http.hpp 2 82.27%
test/fuzz_group.cpp 2 45.77%
src/realm/set.cpp 3 91.07%
Totals Coverage Status
Change from base Build 2356: 0.008%
Covered Lines: 214633
Relevant Lines: 236337

💛 - Coveralls

@jsflax jsflax changed the title Add working_dir to "run hang analyzer" task Reconnect Hang Analyzer to evergreen May 30, 2024
@jsflax jsflax force-pushed the jf/fix-hang-analyzer-evg branch from 64b86be to 7772af2 Compare May 30, 2024 13:11
@jsflax jsflax force-pushed the jf/fix-hang-analyzer-evg branch from 7772af2 to b802f6c Compare May 30, 2024 13:18
@jsflax jsflax changed the title Reconnect Hang Analyzer to evergreen RCORE-2148: Reconnect Hang Analyzer to evergreen May 30, 2024
@jsflax jsflax requested review from jbreams, ironage and michael-wb May 30, 2024 13:24
@jsflax jsflax changed the title RCORE-2148: Reconnect Hang Analyzer to evergreen RCORE-2148 Reconnect Hang Analyzer to evergreen May 30, 2024
Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

echo "No source directory exists. Not running hang analyzer"
exit 1
fi

mkdir realm-core/hang_analyzer_workdir; cd realm-core/hang_analyzer_workdir
mkdir hang_analyzer_workdir; cd hang_analyzer_workdir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a -p so it doesn't fail if the directory already exists (it shouldn't, but just in case)
mkdir -p hang_analyzer_workdir; ...

@jsflax jsflax merged commit 4691492 into master May 30, 2024
34 of 40 checks passed
@jsflax jsflax deleted the jf/fix-hang-analyzer-evg branch May 30, 2024 14:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants