-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCORE-2148 Reconnect Hang Analyzer to evergreen #7719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build jason.flax_720Details
💛 - Coveralls |
jsflax
changed the title
Add
Reconnect Hang Analyzer to evergreen
May 30, 2024
working_dir
to "run hang analyzer" task
jsflax
force-pushed
the
jf/fix-hang-analyzer-evg
branch
from
May 30, 2024 13:11
64b86be
to
7772af2
Compare
jsflax
force-pushed
the
jf/fix-hang-analyzer-evg
branch
from
May 30, 2024 13:18
7772af2
to
b802f6c
Compare
jsflax
changed the title
Reconnect Hang Analyzer to evergreen
RCORE-2148: Reconnect Hang Analyzer to evergreen
May 30, 2024
jsflax
changed the title
RCORE-2148: Reconnect Hang Analyzer to evergreen
RCORE-2148 Reconnect Hang Analyzer to evergreen
May 30, 2024
jbreams
approved these changes
May 30, 2024
michael-wb
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
echo "No source directory exists. Not running hang analyzer" | ||
exit 1 | ||
fi | ||
|
||
mkdir realm-core/hang_analyzer_workdir; cd realm-core/hang_analyzer_workdir | ||
mkdir hang_analyzer_workdir; cd hang_analyzer_workdir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a -p
so it doesn't fail if the directory already exists (it shouldn't, but just in case)
mkdir -p hang_analyzer_workdir; ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hang analyzer became disconnected due to a variable working dir, incorrect precondition checks on the requirements.txt file, and the python venv being updated to 3.12.
Update paths to use
realm-core
as the working directory.Change
-d
check to-f
check forrequirements.txt
precondition.Add
setuptools
torequirements.txt
becausedistutils
is no longer included with python3.12.