Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tool to run the redirect server from the command line #8016

Closed

Conversation

michael-wb
Copy link
Contributor

What, How & Why?

Added a command line tool to the test/object-store/tools directory that runs the redirect server outside of the tests for validating the location endpoint and http/websocket redirection support within Core.

☑️ ToDos

  • [ ] 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed
  • [ ] bindgen/spec.yml, if public C++ API changed

@michael-wb michael-wb added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Aug 30, 2024
@michael-wb michael-wb self-assigned this Aug 30, 2024
@cla-bot cla-bot bot added the cla: yes label Aug 30, 2024
@michael-wb michael-wb requested a review from jbreams August 30, 2024 18:57
Copy link

coveralls-official bot commented Aug 30, 2024

Pull Request Test Coverage Report for Build michael.wilkersonbarker_1375

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 91 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.007%) to 91.095%

Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 88.03%
src/realm/mixed.cpp 1 86.75%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/instructions.hpp 1 76.71%
test/test_query2.cpp 1 98.73%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/sync/client.cpp 3 90.96%
src/realm/sync/noinst/protocol_codec.hpp 3 75.74%
src/realm/table.cpp 3 90.46%
src/realm/sync/instruction_applier.cpp 5 68.01%
Totals Coverage Status
Change from base Build michael.wilkersonbarker_1373: -0.007%
Covered Lines: 217426
Relevant Lines: 238681

💛 - Coveralls

@jbreams
Copy link
Contributor

jbreams commented Sep 3, 2024

Why do we need this?

@michael-wb
Copy link
Contributor Author

Why do we need this?

I had used it while writing the tests for #8011 and thought it might be helpful in the future. I can close the PR if you don't see any value in it.

@jbreams jbreams closed this Sep 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants