Use the sigaction syscall directly on arm64 #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libc wrapper is broken in some way that results in it not working for SIGSEGV. Fixes encryption not working at all on ARM64 Android devices.
|
Awesome! |
|
lgtm 👍 |
|
I have built core for Android, ran the Android unit tests, and ran a simple Android app (as reported by the user) on a Nexus 9 tablet. It seems to run fine 👍 |
| #ifdef REALM_ANDROID | ||
| #include <linux/unistd.h> | ||
| #include <sys/syscall.h> | ||
| #endif |
There was a problem hiding this comment.
Would have been nice with some indentation here, like above.
|
👍 |
kspangsege
pushed a commit
that referenced
this pull request
May 4, 2015
Use the sigaction syscall directly on arm64
|
👍 |
fealebenpae
pushed a commit
that referenced
this pull request
Nov 17, 2020
* update protocol error for sync 4.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bionic libc wrapper is broken in some way that results in it not working for SIGSEGV. Fixes encryption not working at all on ARM64 Android devices.