Made queries use no-copy version of indexed find_all() + Fixed leak in query_engine #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rrrlasse
commented
May 8, 2013
rrrlasse
commented
- Made queries use no-copy version of indexed find_all()
- Fixed leak in query_engine
…htdb Conflicts: src/tightdb/array.cpp src/tightdb/array.hpp src/tightdb/column_string.cpp src/tightdb/column_string.hpp src/tightdb/column_string_enum.hpp src/tightdb/index_string.cpp src/tightdb/index_string.hpp src/tightdb/query_engine.hpp test/TestQuery.cpp
…y row. Only int, float and double supported for now, Operators: equal, not_equal, less, greater, less_equal, greater_equal
| delete[] m_value.data(); | ||
| m_long ? delete(static_cast<ArrayStringLong*>(m_leaf)) : delete(static_cast<ArrayString*>(m_leaf)); | ||
| m_index.Destroy(); | ||
| } | ||
|
|
||
| void Deallocate() |
There was a problem hiding this comment.
In the end all function (except constructors and destructors) should have underscore separated lower case names. How about not increasing the burden?
|
Done reviewing! |
rrrlasse
added a commit
that referenced
this pull request
May 8, 2013
Made queries use no-copy version of indexed find_all() + Fixed leak in query_engine
tgoyne
pushed a commit
that referenced
this pull request
Jul 11, 2018
Performance improvements to column key->ndx mapping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.