Fixes for 'const char*' overloads #97
Merged
+20
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Conflicts: src/tightdb/query.cpp src/tightdb/query.hpp
rrrlasse
added a commit
that referenced
this pull request
May 31, 2013
Fixes for 'const char*' overloads
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to add overloads for begins_with() ends_with() and contains() because these aren't provided in a bool version, and there is nothing else they could conflict with.
The new overloads are moved down under the StringData versions, since they are a mere hack, and therefore are secondary to the StringData versions.
A comment similar to the one in mixed.hpp:113 was added to explain why these seemingly redundant overloads are there.
Parameter name 'value' changed to 'c_str' to make it a little more clear that the functions expect a null-terminated string.
I moved the definitions for the 'const char*' overloads into the header file and added the 'inline' keyword. These overloads are school book examples of what should be marked as inline.
\cc @rrrlasse