Use indexOf in managed list remove

realm · Sep 20, 2022 · b14a440 · b14a440
1 parent ff2ffcc
commit b14a440
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/lib/src/list.dart b/lib/src/list.dart
@@ -83,6 +83,17 @@ class ManagedRealmList<T extends Object?> with RealmEntity, ListMixin<T> impleme
  }
  }
 
+ @override
+ bool remove(covariant T element) {
+ if (element is RealmObject && !element.isManaged) {
+ throw RealmStateError('Cannot call remove on a managed list with an element that is an unmanaged object');
+ }
+ final index = indexOf(element);
+ final found = index > 0;
+ if (found) removeAt(index);
+ return found;
+ }
+
  @override
  T operator [](int index) {
  if (index < 0) {

diff --git a/test/list_test.dart b/test/list_test.dart
@@ -716,6 +716,20 @@ Future<void> main([List<String>? args]) async {
  expect(realm.write(() => team.players.remove(dan)), isFalse);
 
  expect(team.players.every((p) => p.isValid && p.isManaged), isTrue);
+
+ expect(
+ () => (team.players as List<Object>).indexOf("wrong type"), // ignore: unnecessary_cast
+ throwsA(isA<TypeError>()),
+ );
+
+ expect(
+ () => team.players.remove(Person('alice')),
+ throwsA(isA<RealmStateError>().having(
+ (e) => e.message,
+ 'message',
+ 'Cannot call remove on a managed list with an element that is an unmanaged object',
+ )),
+ );
  });
 
  test('ManagedRealmList.setRange', () {