Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set missing SyncError codes to Unknown #1041

Closed
sync-by-unito bot opened this issue Nov 18, 2022 · 0 comments · Fixed by #1052
Closed

Set missing SyncError codes to Unknown #1041

sync-by-unito bot opened this issue Nov 18, 2022 · 0 comments · Fixed by #1052
Assignees
@desistefanova

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 18, 2022 •
edited
Loading

Instead of throwing an Exception when the Error Category is known but the error code is unknown it is better to set the code to Unknown.

realm-dart/lib/src/configuration.dart

Line 746 in 64cde9f

throw RealmError("Unknown GeneralSyncErrorCode");

realm-dart/common/lib/src/realm_types.dart

Line 326 in 64cde9f

throw RealmError("Unknown SyncConnectionErrorCode");

Check also all the other error enums.
@desistefanova desistefanova mentioned this issue Nov 30, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@desistefanova desistefanova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set missing SyncError codes to Unknown realm/realm-dart
1 participant
@desistefanova