Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set missing SyncError codes to Unknown #1052

Merged
merged 7 commits into from
Dec 2, 2022
Merged

Set missing SyncError codes to Unknown #1052

merged 7 commits into from
Dec 2, 2022

Conversation

desistefanova
Copy link
Contributor

Fixes #1041

@cla-bot cla-bot bot added the cla: yes label Nov 30, 2022
@coveralls
Copy link

coveralls commented Nov 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3600289748

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.131%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/configuration.dart 0 1 0.0%
Totals Coverage Status
Change from base Build 3577650470: 0.03%
Covered Lines: 2780
Relevant Lines: 3119
💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review November 30, 2022 23:21
blagoev
blagoev suggested changes Dec 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
common/lib/src/realm_types.dart Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
blagoev
blagoev suggested changes Dec 2, 2022
View reviewed changes
common/lib/src/realm_types.dart Outdated Show resolved Hide resolved
nielsenko
nielsenko approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blagoev blagoev merged commit 669ea09 into master Dec 2, 2022
@blagoev blagoev deleted the sync_error_codes branch December 2, 2022 11:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko nielsenko approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set missing SyncError codes to Unknown
5 participants
@desistefanova @coveralls @nirinchev @blagoev @nielsenko