-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyncSessionErrorCode.compensatingWrite(231) #1022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3470250968
💛 - Coveralls |
desistefanova
requested review from
blagoev,
nirinchev and
nielsenko
and removed request for
nirinchev
November 11, 2022 07:44
desistefanova
changed the title
syncErrorHandler - provide better details
SyncSessionErrorCode.compensatingWrite(231)
Nov 11, 2022
nielsenko
approved these changes
Nov 11, 2022
blagoev
approved these changes
Nov 15, 2022
nirinchev
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we write a test for this? I don't see a reason why it wouldn't work, but it would be nice to have a test that verifies it.
I added one test. |
blagoev
approved these changes
Nov 15, 2022
nirinchev
reviewed
Nov 15, 2022
nirinchev
approved these changes
Nov 15, 2022
Co-authored-by: Nikola Irinchev <irinchev@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [Bug]: syncErrorHandler doesn't occur because of mapping error codes exception #1024