Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update realm-core to v13.1.0 #1042

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Update realm-core to v13.1.0 #1042

merged 3 commits into from
Nov 25, 2022

Conversation

nielsenko
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 19, 2022

Pull Request Test Coverage Report for Build 3546560009

  • 30 of 30 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.999%

Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.48%
lib/src/list.dart 2 84.92%
Totals Coverage Status
Change from base Build 3546249228: -0.02%
Covered Lines: 2775
Relevant Lines: 3118

💛 - Coveralls

Copy link
Contributor

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes in #974 that test if beginWriteAsync and commitWriteAsync throw the correct error. I will apply them separately after we merge this PR.

@nielsenko nielsenko changed the title Update realm-core to v13.0.0 Update realm-core to v13.1.0 Nov 23, 2022
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small suggestions

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/session.dart Show resolved Hide resolved
@nielsenko nielsenko merged commit 9e887f4 into master Nov 25, 2022
@nielsenko nielsenko deleted the kn/update-core branch November 25, 2022 11:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants