support realm refresh() #1046
Merged
support realm refresh() #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4044219192
💛 - Coveralls |
nirinchev
reviewed
Nov 30, 2022
don't invoke the callback if the onRefresh registration fails fix test for outside transaction registration
desistefanova
approved these changes
Dec 2, 2022
nielsenko
suggested changes
Dec 2, 2022
nielsenko
reviewed
Dec 2, 2022
|
blocked on realm/realm-core#6075 |
nielsenko
reviewed
Jan 30, 2023
blagoev
commented
Jan 30, 2023
Co-authored-by: blagoev <lubo@blagoev.com>
nielsenko
approved these changes
Jan 30, 2023
desistefanova
added a commit
that referenced
this pull request
Feb 1, 2023
* support realm refresh() * fix up changelog * support refresh callback * fix tests, add not called test * make operation a no op if the callback was not registered successfully don't invoke the callback if the onRefresh registration fails fix test for outside transaction registration * fix expectation * fix refresh callback implementation. * add refreshAsync to changelog * use proper future timeout * fix test * Update realm in another Isolate * Disable auto refresh realm and refresh manually * Return result from refreshAsync * Fix API doc * Fix API doc * Repair a test * Code review changes * Code review changes * Code review changes * Apply suggestions from code review Co-authored-by: blagoev <lubo@blagoev.com> * Code review changes --------- Co-authored-by: Desislava Stefanova <dst.stefanova@gmail.com> Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Realm.refresh() and onRefresh callbacks
#793