Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to analyzer 5+ #1072

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Update to analyzer 5+ #1072

merged 3 commits into from
Jan 3, 2023

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Dec 19, 2022 •
edited
Loading

Fixes: #1070, fixes: #1073

@cla-bot cla-bot bot added the cla: yes label Dec 19, 2022
@nielsenko nielsenko force-pushed the kn/update-analyzer branch 2 times, most recently from 88e59ea to f662b9f Compare December 19, 2022 09:17
@coveralls
Copy link

coveralls commented Dec 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3744460990

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 89.16%
Changes Missing Coverage Covered Lines Changed/Added Lines %
generator/lib/src/pseudo_type.dart 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
lib/src/realm_class.dart 1 93.33%
Totals Coverage Status
Change from base Build 3741611178: -0.02%
Covered Lines: 2813
Relevant Lines: 3155
💛 - Coveralls

@nielsenko nielsenko requested a review from blagoev December 19, 2022 10:45
@nielsenko nielsenko marked this pull request as ready for review December 19, 2022 14:22
@desistefanova
Copy link
Contributor

In this case we will have to remove the changelog item :
"Bump minimum Dart SDK version to 2.17.5 due to an issue with the Dart virtual machine when implementing Finalizable. (dart-lang/sdk#49075)"
And also I have to update the docs: mongodb/docs-realm#2416

This was referenced Dec 19, 2022
Merged
Merged
blagoev
blagoev suggested changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should do this yet. Lets discuss when is the appropriate time to do it.

@nielsenko
Copy link
Contributor Author

nielsenko commented Dec 19, 2022 •
edited
Loading

If we want to work with analyzer ^5.0.0 (which was released 3 month ago) we need latest stable, ie. 3.3.10, to do this. Community seems to want this.

@nielsenko nielsenko requested a review from blagoev December 20, 2022 21:50
@nielsenko
Copy link
Contributor Author

If we want to work with analyzer ^5.0.0 (which was released 3 month ago) we need latest stable, ie. 3.3.10, to do this. Community seems to want this.

My mistake, I'll drop this requirement

@nielsenko nielsenko merged commit 2e6e547 into main Jan 3, 2023
@nielsenko nielsenko deleted the kn/update-analyzer branch January 3, 2023 18:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova approved these changes

@blagoev blagoev blagoev approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade analyzer in realm_generator [Bug]: Can't generate code
4 participants
@nielsenko @coveralls @desistefanova @blagoev