You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Decimal128. This behaves as you would expect from IEEE754, including behaviour of NaN comparison, ie. Nan == NaN is false. Note that you can still query for a NaN value in the DB as realm-core treats NaN as any other (single) value, to have a total order.
Be aware that the Dart compareTo method is implemented to honor the total ordering of IEEE754-2008 paragraf 5.10, which mimic the behaviour of Dart double. Note that this means that compareTo will order any values, including +/- NaN, +/- Infinity as well as +/- 0. This implies the compareTo operation is different from the partial ordering given by operator==, operator<, and operator>. For example, IEEE doubles impose that Decimal128.zero == -Decimal128.zero and all comparison operations on NaN return false.
This function imposes a complete ordering for doubles. When using compareTo, the following properties hold:
All NaN values are considered equal, and greater than any numeric value.
-Decimal128.zero is less than Decimal128.zero (and the integer 0), but greater than any non-zero negative value.
Negative infinity is less than all other values and positive infinity is greater than all non-NaN values.
All other values are compared using their numeric value.
@dotjon0 I will need to postpone this work about a week, but then I'll return to it. I hope it is not inconvenient.
Note that it is a fairly rudimentary implementation supporting just basic the arithmetic operations (+,-,*,/, and abs())and the ability to convert to from int, double, and String.
@dotjon0 I will need to postpone this work about a week, but then I'll return to it. I hope it is not inconvenient.
Note that it is a fairly rudimentary implementation supporting just basic the arithmetic operations (+,-,*,/, and abs())and the ability to convert to from int, double, and String.
@nielsenko no need to apologise, we are just very grateful for this feature going in! Functionality sounds great. Thank you so much
Assigning a sub-struct from a heap allocated struct to a stack allocated
struct, does not actually copy the bytes. This is a work-around for that
issue.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nielsenko
force-pushed
the
kn/decimal128
branch
2 times, most recently
from
Add support for
Decimal128. This behaves as you would expect from IEEE754, including behaviour of NaN comparison, ie.Nan == NaNisfalse. Note that you can still query for aNaNvalue in the DB as realm-core treatsNaNas any other (single) value, to have a total order.Be aware that the Dart
compareTomethod is implemented to honor the total ordering of IEEE754-2008 paragraf 5.10, which mimic the behaviour of Dartdouble. Note that this means thatcompareTowill order any values, including+/- NaN,+/- Infinityas well as+/- 0. This implies thecompareTooperation is different from the partial ordering given byoperator==,operator<, andoperator>. For example, IEEE doubles impose thatDecimal128.zero == -Decimal128.zeroand all comparison operations on NaN return false.This function imposes a complete ordering for doubles. When using
compareTo, the following properties hold:-Decimal128.zerois less thanDecimal128.zero(and the integer 0), but greater than any non-zero negative value.