Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kn/fix realm set #1212

Merged
merged 6 commits into from
Mar 20, 2023
Merged

kn/fix realm set #1212

merged 6 commits into from
Mar 20, 2023

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Mar 16, 2023 •
edited
Loading

  • Add expect to show RealmSets of objects are broken
  • Fix RealmSet<T> where T extends RealmObject and RealmSet<RealmValue>
  • Update CHANGELOG

Fixes: #1217

@cla-bot cla-bot bot added the cla: yes label Mar 16, 2023
@coveralls
Copy link

coveralls commented Mar 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4461430361

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 89.077%
Totals Coverage Status
Change from base Build 4449152578: 0.1%
Covered Lines: 3050
Relevant Lines: 3424
💛 - Coveralls

@nielsenko nielsenko requested review from blagoev and desistefanova and removed request for blagoev March 16, 2023 21:21
@nielsenko nielsenko marked this pull request as ready for review March 16, 2023 23:57
@nielsenko nielsenko merged commit b74bd4f into main Mar 20, 2023
@nielsenko nielsenko deleted the kn/fix-realm-set branch March 20, 2023 11:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@desistefanova desistefanova desistefanova approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RealmSet<T> broken when T is RealmObject or RealmValue (containing RealmObject)
4 participants
@nielsenko @coveralls @blagoev @desistefanova