Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kn/RealmSet.asResults #1214

Merged
merged 4 commits into from
Mar 19, 2023
Merged

kn/RealmSet.asResults #1214

merged 4 commits into from
Mar 19, 2023

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Mar 16, 2023 •
edited
Loading

  • Implement RealmSet.asResults()
  • Update CHANGELOG

Fixes: #1218

@cla-bot cla-bot bot added the cla: yes label Mar 16, 2023
@nielsenko nielsenko force-pushed the kn/RealmSet.asResults branch from 134cde9 to b27a069 Compare March 16, 2023 23:57
@coveralls
Copy link

coveralls commented Mar 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4445325768

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.95%
Totals Coverage Status
Change from base Build 4437388393: 0%
Covered Lines: 3051
Relevant Lines: 3430
💛 - Coveralls

@nielsenko nielsenko requested review from blagoev and desistefanova and removed request for blagoev March 17, 2023 07:55
@nielsenko nielsenko marked this pull request as ready for review March 17, 2023 07:55
desistefanova
desistefanova suggested changes Mar 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nielsenko nielsenko requested a review from desistefanova March 17, 2023 10:16
@blagoev blagoev merged commit 1b1caac into main Mar 19, 2023
@blagoev blagoev deleted the kn/RealmSet.asResults branch March 19, 2023 15:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova approved these changes

@blagoev blagoev blagoev approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RealmSet.asResults() missing
4 participants
@nielsenko @coveralls @blagoev @desistefanova