-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compensating write error details #1291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5335676331
💛 - Coveralls |
blagoev
suggested changes
May 29, 2023
desistefanova
commented
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I handled most of the comments. I will add a discussion point for some of the rest comments.
Co-authored-by: blagoev <lubo@blagoev.com>
blagoev
reviewed
Jun 17, 2023
…com/realm/realm-dart into ds/compensating_write_error_details # Conflicts: # lib/src/native/realm_core.dart
blagoev
suggested changes
Jun 21, 2023
Co-authored-by: blagoev <lubo@blagoev.com>
blagoev
approved these changes
Jun 21, 2023
nielsenko
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A part for the .orig file that was added this LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose Compensating Write error details. Added a new sync error type
CompensatingWriteError
.This PR introduces some changes in
ClientResetError
constructor, in order to be aligned to the other SDKs. This constructor is not expected to be used by the users, because this error is created internally.The constructors for all the SyncError types are deprecated.
A new property sessionErrorCode of type
SyncSessionErrorCode
is added, since the error category is of typesession
when theClientResetError
is created as an argument ofManualRecoveryHandler
.The existing
ClientResetError.code
will returnSyncClientErrorCode.autoClientResetFailure
only if the recovery fails on the client side and theClientResetError
is created as an argument ofManualResetFallback
.Fixes #1223