Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compensating write error details #1291

Merged
merged 78 commits into from
Jun 21, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented May 26, 2023

  • Expose Compensating Write error details. Added a new sync error type CompensatingWriteError.

  • This PR introduces some changes in ClientResetError constructor, in order to be aligned to the other SDKs. This constructor is not expected to be used by the users, because this error is created internally.

  • The constructors for all the SyncError types are deprecated.

  • A new property sessionErrorCode of type SyncSessionErrorCode is added, since the error category is of type session when the ClientResetError is created as an argument of ManualRecoveryHandler.

  • The existing ClientResetError.code will return SyncClientErrorCode.autoClientResetFailure only if the recovery fails on the client side and the ClientResetError is created as an argument of ManualResetFallback.

Fixes #1223

@coveralls
Copy link

coveralls commented May 26, 2023

Pull Request Test Coverage Report for Build 5335676331

  • 92 of 114 (80.7%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall First build on ds/compensating_write_error_details at 88.614%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/native/realm_core.dart 52 57 91.23%
lib/src/configuration.dart 40 57 70.18%
Totals Coverage Status
Change from base Build 5334649138: 88.6%
Covered Lines: 3222
Relevant Lines: 3636

💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review May 26, 2023 15:45
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
Copy link
Contributor Author

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I handled most of the comments. I will add a discussion point for some of the rest comments.

lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
src/realm_dart_sync.cpp Outdated Show resolved Hide resolved
@desistefanova desistefanova marked this pull request as ready for review June 16, 2023 20:10
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Show resolved Hide resolved
lib/src/configuration.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/configuration.dart Show resolved Hide resolved
Co-authored-by: blagoev <lubo@blagoev.com>
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A part for the .orig file that was added this LGTM.

lib/src/native/realm_core.dart.orig Outdated Show resolved Hide resolved
@desistefanova desistefanova merged commit 6218377 into main Jun 21, 2023
@desistefanova desistefanova deleted the ds/compensating_write_error_details branch June 21, 2023 15:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Compensating Write error details
4 participants