binary type support #1320
Merged
binary type support #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump agp version
anonymize bundle id
# Conflicts: # lib/src/native/realm_core.dart
blagoev
commented
Jun 15, 2023
| @@ -16,7 +16,8 @@ | |||
| ## 1.2.0 (2023-06-08) | |||
|
|
|||
| ### Enhancements | |||
| * Added support for Full-Text search (simple term) queries. ([#1300](https://github.com/realm/realm-dart/pull/1300)) | |||
| * Added support binary data type. ([#1320](https://github.com/realm/realm-dart/pull/1320)) | |||
| * Added support for Full-Text search (simple term) queries. ([#1300](https://github.com/realm/realm-dart/pull/1300)) | |||
There was a problem hiding this comment.
this was just formatted
Pull Request Test Coverage Report for Build 5311844051
💛 - Coveralls |
nielsenko
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Already discussed on round-table yesterday. To summarize:
- I like that we use
Uint8LIston the interface. - I don't off the top of my mind have a better way to handle default values for binary.
- We could consider creating a
Matcherthat knows how to compareUint8Lists to avoid special cases in the tests, but I don't think it important. - Hopefully we can improve performance once we use the new binding generator.
desistefanova
approved these changes
Jun 19, 2023
Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Binary type support
fixes #1185