Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

realm open async #1369

Merged
merged 51 commits into from
Aug 14, 2023
Merged

realm open async #1369

merged 51 commits into from
Aug 14, 2023

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Aug 4, 2023 •
edited
Loading

Fixes #1338
Enables session multiplexing, now that is was fixed in Core realm/realm-core#6656

@cla-bot cla-bot bot added the cla: yes label Aug 4, 2023
@blagoev blagoev added the no-changelog Used to skip the changelog check label Aug 4, 2023
@blagoev blagoev removed the no-changelog Used to skip the changelog check label Aug 4, 2023
@blagoev blagoev added the no-changelog Used to skip the changelog check label Aug 7, 2023
@coveralls
Copy link

coveralls commented Aug 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5837097777

  • 82 of 84 (97.62%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 89.002%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/realm_class.dart 30 31 96.77%
lib/src/session.dart 7 8 87.5%
Totals Coverage Status
Change from base Build 5784138270: 0.1%
Covered Lines: 3310
Relevant Lines: 3719
💛 - Coveralls

@blagoev blagoev removed the no-changelog Used to skip the changelog check label Aug 9, 2023
@blagoev blagoev marked this pull request as ready for review August 9, 2023 14:26
@blagoev blagoev marked this pull request as draft August 9, 2023 14:26
@blagoev
fix native struct sizes
3b85c77 
enable multiplexing
@blagoev blagoev marked this pull request as ready for review August 9, 2023 14:38
desistefanova
desistefanova reviewed Aug 10, 2023
View reviewed changes
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
.github/workflows/flutter-desktop-tests.yml Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
nielsenko
nielsenko reviewed Aug 10, 2023
View reviewed changes
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/realm_class.dart Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
blagoev added 8 commits August 10, 2023 13:21
@blagoev
remove null check
df11bdc
@blagoev
revert null check. (fooled by the analyzer)
6ef613c
@blagoev
don't use broadcast
7dd5ac1
@blagoev
check token isCancelled inside CancellableFuture callback
94a81d1 
use try finally for pgoress subscription cancelations
Use CancellableCompleter for openRealmAsync. Core does not invoke the callback on cancellation.
@blagoev
force rebuild
897f971
@blagoev
revert cache.
15916eb 
filter tests
@blagoev
force release
bc9f4f9
@blagoev
only linux ci
6c4b676
nielsenko
nielsenko approved these changes Aug 12, 2023
View reviewed changes
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
@blagoev blagoev merged commit 4ad1fe5 into main Aug 14, 2023
@blagoev blagoev deleted the blagoev/realmOpenAsync branch August 14, 2023 09:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova approved these changes

@nielsenko nielsenko nielsenko approved these changes

Assignees

@blagoev blagoev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate using async open for FLX Realms
4 participants
@blagoev @coveralls @nielsenko @desistefanova