Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle user errors in client reset callbacks #1447

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Handle user errors in client reset callbacks #1447

merged 3 commits into from
Dec 8, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Dec 8, 2023 •
edited
Loading

Add SyncError.innerError that holds the original error thrown if a user-supplied callback for before/after reset throws.

@nirinchev nirinchev mentioned this pull request Dec 8, 2023
Closed
Base automatically changed from ni/app-isolates to main December 8, 2023 01:33
@nirinchev nirinchev force-pushed the ni/client-reset-error branch from ed84504 to 196c1fb Compare December 8, 2023 01:34
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7136229375

  • 16 of 19 (84.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on ni/client-reset-error at 88.471%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/native/realm_core.dart 9 10 90.0%
lib/src/configuration.dart 7 9 77.78%
Totals Coverage Status
Change from base Build 7136220928: 88.5%
Covered Lines: 3484
Relevant Lines: 3938
💛 - Coveralls

@nirinchev nirinchev marked this pull request as ready for review December 8, 2023 11:33
@nirinchev nirinchev merged commit 5ba92e8 into main Dec 8, 2023
46 of 49 checks passed
@nirinchev nirinchev deleted the ni/client-reset-error branch December 8, 2023 15:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nirinchev nirinchev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nirinchev