Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate core version with 'git describe' and update automatically in changelog as well #1510

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Calculate core version with 'git describe' and update automatically in changelog as well #1510

wants to merge 1 commit into from

Conversation

nielsenko
Copy link
Contributor

This PR updates the way we calculate the core version to allow us to use unofficial releases, and still report a unique tag, instead of just tagging with the version number of the lates official release.

It just uses git describe instead of parsing the dependencies.list file.

git describe --abbrev=5 do the right thing on pure tagged commits as well, fx.

  • a5e87a39c (tag: v13.26.0) core v13.26.0

produces:

realm-core (a5e87a3) [$] via △ v3.28.2 via  v14.21.3 via 🐦 v5.8.1
❯ git describe --abbrev=5
v13.26.0

@cla-bot cla-bot bot added the cla: yes label Feb 2, 2024
@nielsenko nielsenko added the no-changelog Used to skip the changelog check label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nielsenko nielsenko

Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nielsenko