Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realm delete many #153

Merged
merged 27 commits into from
Jan 11, 2022
Merged

realm delete many #153

merged 27 commits into from
Jan 11, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Dec 29, 2021

realm.deleteMany implemented "Fixes #60".
Support RealmResults for..in "Fixes #37" without snapshot

lib/src/results.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions and nits from me - I was just curious about the PR.

lib/src/results.dart Outdated Show resolved Hide resolved
test/realm_test.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/results.dart Show resolved Hide resolved
lib/src/results.dart Outdated Show resolved Hide resolved
lib/src/results.dart Outdated Show resolved Hide resolved
lib/src/results.dart Outdated Show resolved Hide resolved
@bmunkholm
Copy link
Contributor

Please link to the issues this resolves with "Fixes #xyz".

@desistefanova
Copy link
Contributor Author

Please link to the issues this resolves with "Fixes #xyz".

OK, thanks. Done.

lib/src/results.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Show resolved Hide resolved
@blagoev
Copy link
Contributor

blagoev commented Jan 7, 2022

also we should snapshot before iteration

@nirinchev
Copy link
Member

Note that snapshotting is only possible for object collections - I don't think dart supports results of primitives yet, but when you do, you won't be able to snapshot those.

@desistefanova desistefanova changed the title Realm.remove many Realm delete many Jan 7, 2022
@desistefanova desistefanova changed the title Realm delete many realm delete many Jan 7, 2022
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 7, 2022
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider name change

lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
@desistefanova desistefanova merged commit 4b89c39 into master Jan 11, 2022
@desistefanova desistefanova deleted the Realm.RemoveMany branch January 11, 2022 17:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement deleteMany Support Results for..in
5 participants