Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop final requirement on primary keys for now #240

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Drop final requirement on primary keys for now #240

merged 2 commits into from
Feb 7, 2022

Conversation

nielsenko
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla: yes label Feb 4, 2022
@desistefanova
Copy link
Contributor

Do we already allow PK editing? Which is the related issue?

@nielsenko
Copy link
Contributor Author

Do we already allow PK editing? Which is the related issue?

No. It will be a runtime error, if you try. But the point is that defining it as late final String pk it is still not a compile time error, due to the somewhat odd behaviour of public late final fields without initialisers. So @blagoev would like us to raise this restriction.

@nielsenko nielsenko linked an issue Feb 7, 2022 that may be closed by this pull request
Relax final constraint on primary keys #243
Closed
blagoev
blagoev suggested changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add changelog entry

@nielsenko nielsenko requested a review from blagoev February 7, 2022 16:34
@nielsenko nielsenko merged commit f0a0e57 into master Feb 7, 2022
@nielsenko nielsenko deleted the relax-final-pk-constraint branch February 7, 2022 18:06
@SPSpisoft SPSpisoft mentioned this pull request Mar 13, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@desistefanova desistefanova Awaiting requested review from desistefanova

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relax final constraint on primary keys
3 participants
@nielsenko @desistefanova @blagoev