Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration - disable format upgrade #310

Merged
merged 33 commits into from
Apr 11, 2022
Merged

configuration - disable format upgrade #310

merged 33 commits into from
Apr 11, 2022

Conversation

desistefanova
Copy link
Contributor

Implement configuration property - disableFormatUpgrade. Fixes #297.

@cla-bot cla-bot bot added the cla: yes label Mar 23, 2022
@desistefanova desistefanova marked this pull request as draft March 23, 2022 22:45
@desistefanova desistefanova marked this pull request as ready for review March 24, 2022 15:52
@coveralls
Copy link

coveralls commented Mar 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2101699414

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.841%
Totals Coverage Status
Change from base Build 2051839718: 0.0%
Covered Lines: 394
Relevant Lines: 429
💛 - Coveralls

@desistefanova desistefanova marked this pull request as draft March 25, 2022 05:56
@desistefanova desistefanova marked this pull request as ready for review March 28, 2022 20:14
@desistefanova desistefanova requested a review from nirinchev April 1, 2022 13:32
nirinchev
nirinchev requested changes Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
test/configuration_test.dart Outdated Show resolved Hide resolved
test/test.dart Outdated Show resolved Hide resolved
test/configuration_test.dart Outdated Show resolved Hide resolved
@desistefanova @nirinchev
Update CHANGELOG.md
b445dcc 
Co-authored-by: Nikola Irinchev <irinchev@me.com>
@desistefanova desistefanova requested a review from nirinchev April 6, 2022 09:10
blagoev
blagoev suggested changes Apr 11, 2022
View reviewed changes
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
blagoev
blagoev suggested changes Apr 11, 2022
View reviewed changes
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
@desistefanova desistefanova merged commit 8508780 into master Apr 11, 2022
@desistefanova desistefanova deleted the disable_format_upgrade branch April 11, 2022 16:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev nirinchev approved these changes

@nielsenko nielsenko Awaiting requested review from nielsenko

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support realm disable format upgrade
4 participants
@desistefanova @coveralls @nirinchev @blagoev