Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for objectId #468

Merged
merged 2 commits into from
Apr 12, 2022
Merged

add support for objectId #468

merged 2 commits into from
Apr 12, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Apr 12, 2022

support objectId
use custom line by line matcher for generator tests
this supersedes #460
fixes #461

@blagoev
support objectId
5df9372 
use custom line by line matcher for generator tests
@cla-bot cla-bot bot added the cla: yes label Apr 12, 2022
@blagoev blagoev requested a review from desistefanova April 12, 2022 11:22
@coveralls
Copy link

coveralls commented Apr 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2154651999

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 91.784%
Totals Coverage Status
Change from base Build 2153337873: -0.06%
Covered Lines: 391
Relevant Lines: 426
💛 - Coveralls

@blagoev blagoev merged commit c3e48f1 into master Apr 12, 2022
@blagoev blagoev deleted the support-object-id branch April 12, 2022 11:42
@blagoev blagoev mentioned this pull request Apr 12, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev left review comments

@desistefanova desistefanova desistefanova approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ObjectId
4 participants
@blagoev @coveralls @nirinchev @desistefanova