-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application login user #469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop once stable is updated with finalizer fix. Don't merge before that!
Co-authored-by: blagoev <lubo@blagoev.com>
…ser and Credentials)
…hat will keep the corresponding dart object alive.
…ue on isolate shutdown: dart-lang/sdk#48321
# Conflicts: # CHANGELOG.md # lib/src/realm_class.dart
change user login to use persistent handle for the completer object
blagoev
requested review from
nirinchev and
nielsenko
and removed request for
nirinchev
April 20, 2022 15:52
add application category
nirinchev
reviewed
Apr 20, 2022
nielsenko
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us discuss further at the round-table tomorrow
nirinchev
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass - we probably need a lot more tests and also to expose the properties on the user, but I guess those can come as a follow-up PR.
remove dead env vars usage
…onfigHandle inside getApp since they are not needed anywhere else. This allows the GC to collect them when out of scope. Native instances are preserved by Core
nielsenko
approved these changes
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application login user. Fixes #407
Fixes http transport headers enumeration