Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support calling custom reset password functions #483

Merged
merged 118 commits into from
Apr 22, 2022
Merged

support calling custom reset password functions #483

merged 118 commits into from
Apr 22, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Apr 19, 2022

closes #482

nielsenko and others added 30 commits March 29, 2022 09:49
@nielsenko
Rollback Dart_WeakHandle finalizer hack
453e018
@nielsenko
Use dart main/flutter beta in github actions.
8430d42 
Drop once stable is updated with finalizer fix.
Don't merge before that!
@nielsenko
Add dart specific support for realm_http_transport_new
e847de2 
Update build
@nielsenko
Wire up realm_core
6a5c9c4
@nielsenko @blagoev
Apply suggestions from code review
fca9182 
Co-authored-by: blagoev <lubo@blagoev.com>
@nielsenko
Copy all info from realm_http_request before starting async request
435e484
@nielsenko
Added ApplicationConfiguration
d7207d9
@nielsenko
Added Application class with async logIn method (includes stubs for U…
ea8d7ef 
…ser and Credentials)
@desistefanova
Implement email/password provider
b4eaf29
@desistefanova
Implement RegisterUser in Application emailPasswordProvider
5e887a0
@desistefanova
test commented
b034700
@desistefanova
CHANGELOG.md
44625d4
@nielsenko
Use common GCHandle class for userdata on all callbacks
a54b1a8
@nielsenko
Support hard gc handles as well, as suggested by Yavor. Ie. handles t…
6ae70e2 
…hat will keep the corresponding dart object alive.
@nielsenko
Backport to dart 2.16 where we have to work around a finalization iss…
c81e0c0 
…ue on isolate shutdown: dart-lang/sdk#48321
@nielsenko
Add support for http_transport
6899dc8
@nielsenko
Added ApplicationConfiguration
9a17d45
@nielsenko
Update docs on public interface
73e2e4c
@nielsenko
Address PR feedback
0baa62f
@nielsenko
Added Application class with async logIn method (includes stubs for U…
20e95af 
…ser)
@nielsenko
Add testWithBass function
d63f205
@desistefanova
Merge branch 'master' into realm_app_config
0cdf4b7
@desistefanova
Update CHANGELOG.md
b9cc163
@desistefanova
Merge branch 'realm_app_config' into realm_app
8448ffd
@desistefanova
Commit after merge
7ff02ef
@desistefanova
Fixes after merge
fc5e481
@desistefanova
Merge branch 'realm_app'
c1cb35e
@desistefanova
Fixes after merge
e07be97
@desistefanova
Remove user and login
b7ddc96
@desistefanova
size of handles
938a168
@blagoev
Merge branch 'auth_provider_register_email' into emailpassword-confir…
7bc1377 
…m-user
@blagoev
Merge branch 'emailpassword-confirm-user' into emailpassword-resend-c…
3457d72 
…onfirm
@blagoev
use persistent handle
5039965
@blagoev
Merge branch 'emailpassword-resend-confirm' into emailpassword-reset-…
6c3205a 
…password
@blagoev
use persistent handle
3196b88
@blagoev
fix
2507a00
@blagoev
Merge branch 'auth_provider_register_email' into emailpassword-confir…
5d1ce11 
…m-user
@blagoev
Merge branch 'emailpassword-confirm-user' into emailpassword-resend-c…
6edb7a0 
…onfirm
@blagoev
Merge branch 'emailpassword-resend-confirm' into emailpassword-reset-…
0e1e870 
…password
@blagoev
remove dead file
46a1dbb
@blagoev
remove dead file
622ad31
@blagoev
remove dead code
892d9c1
@blagoev
Merge branch 'emailpassword-confirm-user' into emailpassword-resend-c…
0f8e85a 
…onfirm
@blagoev
Merge branch 'emailpassword-resend-confirm' into emailpassword-reset-…
e465edc 
…password
@blagoev
Merge branch 'emailpassword-reset-password' into emailpassword-send-r…
9194521 
…eset-password-email
@blagoev
use persistent handle
3aaf397
@blagoev
Merge branch 'emailpassword-send-reset-password-email' into emailpass…
fd73cdf 
…word-custom-reset-password-func
@blagoev
use persistent handle
c686868
@blagoev blagoev marked this pull request as ready for review April 21, 2022 20:16
nirinchev
nirinchev approved these changes Apr 22, 2022
View reviewed changes
lib/src/credentials.dart Outdated Show resolved Hide resolved
nielsenko
nielsenko suggested changes Apr 22, 2022
View reviewed changes
lib/src/credentials.dart Outdated Show resolved Hide resolved
@blagoev blagoev requested a review from nielsenko April 22, 2022 07:34
Base automatically changed from emailpassword-send-reset-password-email to master April 22, 2022 09:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2206982180

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.784%
Totals Coverage Status
Change from base Build 2206971731: 0.0%
Covered Lines: 391
Relevant Lines: 426
💛 - Coveralls

@blagoev blagoev merged commit 816a74d into master Apr 22, 2022
@blagoev blagoev deleted the emailpassword-custom-reset-password-func branch April 22, 2022 10:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

@nielsenko nielsenko nielsenko approved these changes

Assignees

@blagoev blagoev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth Provider: support custom confirmation functions
5 participants
@blagoev @coveralls @nirinchev @nielsenko @desistefanova