Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App config log level and request timeout #566

Merged
merged 11 commits into from
May 17, 2022
Merged

App config log level and request timeout #566

merged 11 commits into from
May 17, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented May 11, 2022 •
edited
Loading

Sync Client Config: set log level. Fixes #372
Sync Client Config: support connection timeout. Fixes #376

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2307647343

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.677%
Totals Coverage Status
Change from base Build 2307529112: 0.0%
Covered Lines: 400
Relevant Lines: 427
💛 - Coveralls

@cla-bot cla-bot bot added the cla: yes label May 12, 2022
@desistefanova desistefanova changed the title App config logs, timeouts, resync App config log level and request timeout May 12, 2022
@desistefanova desistefanova marked this pull request as ready for review May 12, 2022 12:22
blagoev
blagoev suggested changes May 15, 2022
View reviewed changes
test/app_test.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/app.dart Outdated Show resolved Hide resolved
desistefanova and others added 2 commits May 16, 2022 12:11
@desistefanova @blagoev
Update CHANGELOG.md
93ea7f2 
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova
Code review changes
4f860c4
@desistefanova desistefanova requested a review from blagoev May 16, 2022 10:17
blagoev
blagoev approved these changes May 16, 2022
View reviewed changes
test/app_test.dart Outdated Show resolved Hide resolved
@desistefanova desistefanova merged commit 13d2ca0 into master May 17, 2022
@desistefanova desistefanova deleted the app_config_logs_and_timeouts branch May 17, 2022 11:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Client Config: set metadata mode Sync Client Config: set log level
4 participants
@desistefanova @coveralls @blagoev @nielsenko