Sync config client reset handler #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only synchonous version for now, since async C-API doesn't allow userdata
This requires support for out-of-isolate callbacks. To do this a dart specific EventLoopDispatcher and DispatchFreeUserdata is introduced.
…eSyncConfiguration
Also, SubscriptionSet.remove* are now void methods, and corresponding _RealmCore functions uses invokeGetBool.
When nothing is found we should return null on find. Hence we cannot use invokeGetPointer, and also we need to pass null up the conversion stack.
* Add subscription tests to test_driver/realm_test.dart * Allow network use from test_driver app on macos
The add method takes an optional update parameter, that default to false. If true, the add will update the existing subscription if any. Otherwise, it will fail if the subscription exists.
* remove is now called removeByQuery * remove instead takes a Subscription as an argument * removeAll is renamed to clear to match List.clear * all remove* methods now returns a boolean indicating whether a subscription was removed
desistefanova
commented
May 30, 2022
desistefanova
commented
May 30, 2022
desistefanova
commented
May 30, 2022
desistefanova
commented
May 30, 2022
nirinchev
requested changes
May 30, 2022
desistefanova
commented
May 30, 2022
move SyncErrorHandler to a callback handle PR feedback
# Conflicts: # common/lib/src/realm_types.dart # lib/src/configuration.dart
add default SyncClientResetHandler and SyncClientErrorHandlers
nielsenko
approved these changes
May 31, 2022
nirinchev
reviewed
May 31, 2022
desistefanova
commented
May 31, 2022
desistefanova
commented
May 31, 2022
desistefanova
commented
May 31, 2022
desistefanova
commented
May 31, 2022
desistefanova
commented
May 31, 2022
desistefanova
commented
May 31, 2022
desistefanova
commented
May 31, 2022
desistefanova
commented
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support SyncClientResetHandler
Fixup SyncErrors support
fixes #628