Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a matrix to deploy and cleanup apps #673

Merged
merged 5 commits into from
Jun 24, 2022

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jun 17, 2022

This is building on top of #663 by moving the deploy/cleanup steps to separate jobs. This shaves 45-60 seconds from the test jobs and those typically complete by the time the build-native job completes, so tests are ready to run in about a minute.

The reason why this works is twofold:

  1. We can split the deploy-apps job because our tests do not rely on it. The test runner will import the apps if necessary, so in the event of a re-run of the failed job, the test runner will fail to find the apps and import them itself.
  2. We can split the cleanup-apps job because re-running a failed job will also re-run its dependents. In the event of a re-run, the cleanup will still be executed with the run attempt, so it will delete apps created by the test runner.

@nirinchev nirinchev self-assigned this Jun 17, 2022
@cla-bot cla-bot bot added the cla: yes label Jun 17, 2022
@nirinchev nirinchev marked this pull request as ready for review June 17, 2022 11:50
Copy link
Contributor

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cluster names have to be renewed on every 12 h to prevent running tests on automatically deleted clusters. Samples for names are dart16AM, dart16PM, dart17AM.

steps:
- name: Get cluster suffix
id: cluster-name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we return back this step for generating different names on every 12 h?

@desistefanova desistefanova merged commit 1f559c3 into ds/ci_rerun_per_env Jun 24, 2022
@desistefanova desistefanova deleted the ni/rerun-per-env branch June 24, 2022 14:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants