Client reset #925
Merged
Client reset #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
requested changes
Sep 26, 2022
desistefanova
changed the title
Pull Request Test Coverage Report for Build 3393227571
💛 - Coveralls |
desistefanova
changed the title
blagoev
approved these changes
Oct 4, 2022
desistefanova
requested review from
nielsenko and
nirinchev
and removed request for
nirinchev and
nielsenko
nirinchev
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Some names need to be updated to be aligned with the other SDKs. I tried to find the meetings notes from the meeting where the names were decided, but couldn't. In any case, I just copied the names from .NET as those should be the same as what's in other SDKs.
Co-authored-by: Nikola Irinchev <irinchev@me.com>
Co-authored-by: Nikola Irinchev <irinchev@me.com>
Co-authored-by: Nikola Irinchev <irinchev@me.com>
* fixup client reset * Update src/realm_dart_sync.cpp Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com> * Update src/realm_dart_sync.cpp Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com> * reorder parameters * guard the full body of reset the callbacks release unowned realms * don't abbreviate functionname. use simple return. Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com>
Merged
blagoev
reviewed
Nov 3, 2022
blagoev
suggested changes
Nov 3, 2022
blagoev
reviewed
Nov 4, 2022
nielsenko
approved these changes
Nov 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Client Resets support.
Added argument
clientResetHandlerwhen creatingFlexibleSyncConfiguration. There are 4 possible handles that defines the mode of processing data in case of client reset:The default mode is RecoverOrDiscard.
Tests are added.
Fixes #353
Fixes #810