Add UWP test runner #1358
Add UWP test runner #1358
Conversation
| @@ -449,6 +449,39 @@ internal override Expression VisitMethodCall(MethodCallExpression m) | |||
| throw new NotSupportedException($"The method '{m.Method.Name}' is not supported"); | |||
| } | |||
|
|
|||
| // Compares two methods for equality. .NET Native's == doesn't return expected results. | |||
| private static bool AreMethodsSame(MethodInfo first, MethodInfo second) | |||
There was a problem hiding this comment.
Could we compare the MethodHandle property on MethodInfo directly?
There was a problem hiding this comment.
It looks like MethodHandle is not available in .NET Standard 1.4 😞
| @@ -368,7 +368,7 @@ public override int GetHashCode() | |||
| { | |||
| ThrowIfDisposed(); | |||
|
|
|||
| return (int)SharedRealmHandle.DangerousGetHandle(); | |||
| return (int)((long)SharedRealmHandle.DangerousGetHandle() % int.MaxValue); | |||
There was a problem hiding this comment.
What's going on here?
There was a problem hiding this comment.
DangerousGetHandle() returns IntPtr which is long on 64 bit devices. I'm not sure how it has worked until now, but on UWP it consistently overflows. There are different strategies for wrapping it in an int - I chose one that seemed fine, but I'm open to suggestions if anyone has a better idea :)
There was a problem hiding this comment.
Ah, I'm seeing now that it's in GetHashCode. No worries then
| [Values(0, 6, 30, 59)] int mins, | ||
| [Values(0, 6, 30, 59)] int secs, | ||
| [Values(0, 1, 999)] int ms) | ||
| [TestCaseSource(nameof(SetAndGetPropertyTestCases))] |
There was a problem hiding this comment.
.NET Native fails to correctly pass attributes with arrays
| return GetByteArrayBuffer(propertyIndex, 0); | ||
| } | ||
|
|
||
| private unsafe byte[] GetByteArrayBuffer(IntPtr propertyIndex, int size) |
| var path = Path.Combine(assemblyLocation, "lib", "win32", architecture) + Path.PathSeparator + Environment.GetEnvironmentVariable("PATH"); | ||
| Environment.SetEnvironmentVariable("PATH", path); | ||
| } | ||
| catch (PlatformNotSupportedException) |
There was a problem hiding this comment.
I was unable to figure out a way to determine whether we're UWP or regular Windows Desktop app :/ The hack with checking for a Windows Runtime type doesn't work, as you can reference WindowsRuntime in a regular app. Suggestions are welcome.
There was a problem hiding this comment.
Well, if it works with the try/catch let's leave it as it is.
nirinchev
force-pushed
the
ni/uwp-test-runner
branch
from
994bc1e to
725b8c2
Compare
| @@ -368,7 +368,7 @@ public override int GetHashCode() | |||
| { | |||
| ThrowIfDisposed(); | |||
|
|
|||
| return (int)SharedRealmHandle.DangerousGetHandle(); | |||
| return (int)((long)SharedRealmHandle.DangerousGetHandle() % int.MaxValue); | |||
There was a problem hiding this comment.
What's going on here?
Closes #1349
nirinchev
force-pushed
the
ni/uwp-test-runner
branch
from
725b8c2 to
1cdef23
Compare
Realm/Realm.Sync/Realm.Sync.csproj
Outdated
| @@ -80,4 +80,5 @@ | |||
| </ItemGroup> | |||
| <Import Project="$(MSBuildExtensionsPath32)\Microsoft\Portable\$(TargetFrameworkVersion)\Microsoft.Portable.CSharp.targets" /> | |||
| <Import Project="..\..\packages\Fody.2.0.6\build\netstandard1.4\Fody.targets" /> | |||
| <Import Project="..\..\packages\Fody.1.29.4\build\dotnet\Fody.targets" Condition="Exists('..\..\packages\Fody.1.29.4\build\dotnet\Fody.targets')" /> | |||
| @@ -449,6 +449,39 @@ internal override Expression VisitMethodCall(MethodCallExpression m) | |||
| throw new NotSupportedException($"The method '{m.Method.Name}' is not supported"); | |||
| } | |||
|
|
|||
| // Compares two methods for equality. .NET Native's == doesn't return expected results. | |||
| private static bool AreMethodsSame(MethodInfo first, MethodInfo second) | |||
There was a problem hiding this comment.
Could we compare the MethodHandle property on MethodInfo directly?
Description
Part of #1081