Fix .NET Native compilation #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Jan 4, 2021
Comment on lines
-31
to
-33
| [FieldOffset(0)] | ||
| [MarshalAs(UnmanagedType.U1)] | ||
| private bool bool_value; |
There was a problem hiding this comment.
Removing the [MarshalAs] attribute from bool_value appears to fix the issue.
| @@ -11,15 +11,14 @@ | |||
| <AssemblyName>Tests.UWP</AssemblyName> | |||
There was a problem hiding this comment.
Reviewers can ignore changes to this file - since we don't run UWP tests automatically, the project file had rotted a little and needed to bring it up to date to be able to debug things.
| @@ -46,6 +46,9 @@ if(APPLE) | |||
| endif() | |||
| elseif(CMAKE_SYSTEM_NAME MATCHES "^Windows") | |||
| add_definitions(/DWIN32_LEAN_AND_MEAN) | |||
| add_compile_options( | |||
| /MP # Enable multi-processor compilation | |||
There was a problem hiding this comment.
@fealebenpae added this since it seemed like we didn't compile the wrapper sources in parallel.
fealebenpae
approved these changes
Jan 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hopefully fixes #2169.
TODO