Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema cache #2577

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Add schema cache #2577

merged 1 commit into from
Aug 25, 2021

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Aug 23, 2021

Description

Fixes #2194

This will not have massive performance effect for most users as we expect most people to just use the default schema, which is already cached. But for people who do set ObjectClasses, it should speed things up nicely.

Benchmarks

Before the change

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
CreateSchema 3.897 ms 0.0313 ms 0.0261 ms 78.1250 7.8125 - 859 KB
OpenRealm 16.567 ms 0.2680 ms 0.2375 ms 62.5000 - - 898 KB

After the change

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
CreateSchema 2.128 us 0.0090 us 0.0075 us 0.1793 - - 2 KB
OpenRealm 12,254.235 us 230.4506 us 215.5636 us - - - 40 KB

TODO

  • Changelog entry
  • Tests (if applicable)

@nirinchev nirinchev self-assigned this Aug 23, 2021
@nirinchev nirinchev requested a review from papafe August 23, 2021 13:57
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nirinchev nirinchev merged commit cfd6e91 into master Aug 25, 2021
@nirinchev nirinchev deleted the ni/schema-cache branch August 25, 2021 12:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider caching the schema
2 participants