Expose a HttpClientHandler property on app config #2883
Merged
+250
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
approved these changes
Mar 25, 2022
Realm/Realm/Sync/App.cs
Outdated
| @@ -150,6 +153,8 @@ public static App Create(AppConfiguration config) | |||
| } | |||
| } | |||
|
|
|||
| var httpClient = new HttpClient(config.HttpClientHandler ?? new HttpClientHandler()); | |||
There was a problem hiding this comment.
I think we should initialize the AppConfiguration.HttpClientHandler property with the default value, instead of leaving it null and instantiating the default handler here.
Pull Request Test Coverage Report for Build 2051898457
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pulls in the GCHandleHolder mechanics from #2777 as I didn't want to block this on the client reset work.
Fixes #2865
TODO